Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Make ships stop and change direction slowly instead of instantly turning. #7065

Merged
merged 1 commit into from Jan 24, 2019

Conversation

@PeterN
Copy link
Member

PeterN commented Jan 15, 2019

With this patch, ships will now take up to 8 game ticks to make tight turns, which improves their appearance a bit. This is mostly visible when a ship is turning around at a dock.

@andythenorth

This comment has been minimized.

Copy link
Contributor

andythenorth commented Jan 15, 2019

I have tested this, it's a nice improvement.

@J0anJosep

This comment has been minimized.

Copy link
Contributor

J0anJosep commented Jan 15, 2019

I have tested this, it's a nice improvement.

How does it apply to narrow canals or reversing at a lock?

@PeterN PeterN force-pushed the PeterN:ship-tweaks-slow-turning branch from 7318815 to 5075642 Jan 16, 2019
@PeterN

This comment has been minimized.

Copy link
Member Author

PeterN commented Jan 16, 2019

@J0anJosep They'll still turn around, I suppose it may look like there's not enough space to do so, but there's nothing in the system that says how long a ship is.

src/saveload/saveload.cpp Outdated Show resolved Hide resolved
@andythenorth

This comment has been minimized.

Copy link
Contributor

andythenorth commented Jan 16, 2019

It looks a bit silly in canals, the ship overlaps the ground. BUT it looks so much better in other cases that I think it should be shipped anyway.

Maybe canals should need a 2 tile turning place? :) Adds more nuance to ship gameplay?

@J0anJosep

This comment has been minimized.

Copy link
Contributor

J0anJosep commented Jan 17, 2019

I still haven't tried this one. The idea seems interesting, but I am worried about rotation when reversing in narrow canals, ship depots and aqueducts.
I know there have been clipping problems with ships for a long time, and turning around would make them more evident in game.

@PeterN PeterN force-pushed the PeterN:ship-tweaks-slow-turning branch from 5075642 to 1bfe1af Jan 20, 2019
Copy link
Member

LordAro left a comment

Purely with the stock ships, turning around "slowly" on a single tile looks fine

@andythenorth

This comment has been minimized.

Copy link
Contributor

andythenorth commented Jan 21, 2019

Tested, works for me. Nice improvement.

@LordAro LordAro merged commit 2257908 into OpenTTD:master Jan 24, 2019
1 check passed
1 check passed
OpenTTD CI Build #20190120.3 succeeded
Details
@PeterN PeterN deleted the PeterN:ship-tweaks-slow-turning branch Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.