Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: smart town name first steps - #7037 #7068

Closed
wants to merge 1 commit into from

Conversation

@nikolas
Copy link
Contributor

nikolas commented Jan 17, 2019

This adds structure for some basic town naming rules based on location.

When towns are generated, a mask is read for the random name, to see if
it's a suitable name for this town tile. Currently it just prevents
towns from being named with "Puerto" or "havn" if they're not near the
water, and will only do anything on Latin-American, Danish, or Norwegian
town names.

@nikolas nikolas force-pushed the nikolas:smart-town-names branch from e94b3ec to 0c92ebd Jan 17, 2019
@LordAro LordAro added the wip label Jan 17, 2019
This adds structure for some basic town naming rules based on location.

When towns are generated, a mask is read for the random name, to see if
it's a suitable name for this town tile. Currently it just prevents
towns from being named with "Puerto" or "havn" if they're not near the
water, and will only do anything on Latin-American, Danish, or Norwegian
town names.
@nikolas nikolas force-pushed the nikolas:smart-town-names branch from 0c92ebd to 9babb4e Jan 22, 2019
Copy link
Contributor

planetmaker left a comment

I like the idea a lot to choose town names more sensibly wrt location on the map.

However I do not like the idea to go by actual string matching as it is tied to specific strings. There's a LOT of townname NewGRFs out there who could profit from an approach which gives them the same info - or alternatively allows them to provide flags for like "near sea| near river | on mountain | between mountains | near woods | in desert" or similar.

My suggestion as such is to modify the string lists that each string can be accompanied by flags which makes them either favour or avoid certain conditions - and use those flags to decide applicability of the name to a location (maybe introduce one flag 'not generic' which indicates special location recommendation for a name - 'not generic' so that a list without anything set will treat anything as generic name)

@LordAro

This comment has been minimized.

Copy link
Member

LordAro commented Feb 10, 2019

It's an interesting concept, but I think it's far too early in development to be worth PRing. By all means reopen/make a new PR if you progress with it

@LordAro LordAro closed this Feb 10, 2019
@nikolas

This comment has been minimized.

Copy link
Contributor Author

nikolas commented Feb 10, 2019

Cool.. yea i was going to close this PR but wasn't sure if it was better to keep the conversation here. But yeah, I'll open a new PR if I move forward with this implementing some sort of flag system to not make this string-based.

@planetmaker

This comment has been minimized.

Copy link
Contributor

planetmaker commented Feb 10, 2019

It's good to keep the conversation (but even closed it's not gone) You can also re-open this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.