Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Make OPF check reverse only when exiting depot #7071

Conversation

SamuXarick
Copy link
Contributor

@SamuXarick SamuXarick commented Jan 18, 2019

This change will prevent OPF ships from reversing on open water, though, which in my opinion, does make it look good.

Results from testings indicate about 1/3 less cpu usage with this change.

This change will prevent OPF ships from reversing on open water, though, which in my opinion, does make it look good.

Results from testings indicate about 1/3 less cpu usage with this change.
@andythenorth
Copy link
Contributor

@andythenorth andythenorth commented Jan 18, 2019

Thanks. Same comment as I made on #7070. I think it's counter-productive to extend a dead pathfinder, it's testing and maintenance burden, and the possibility of introducing new issues for zero benefit.

That's just my view, others might differ.

@andythenorth
Copy link
Contributor

@andythenorth andythenorth commented Jan 19, 2019

Closing this thanks. OPF is intended to be as close to the original path finder as possible (given all the extensions OTTD has over TTD), so even subjectively undesirable behaviour should be kept. Pathfinder improvements should be focussed at YAPF in most cases.

@SamuXarick SamuXarick deleted the opf-reverse-only-when-leaving-depot branch Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants