Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #7090: Close Query String window after rebuilding AI/GS settings #7093

Merged

Conversation

@SamuXarick
Copy link
Contributor

SamuXarick commented Jan 24, 2019

No description provided.

@glx22
Copy link
Contributor

glx22 commented Jan 26, 2019

This PR fixes one specific problem but there are more things to fix to do it properly. The AI windows need a closer look to find and fix all missing invalidation/close.

Copy link
Member

michicc left a comment

It might not fix everything that is wrong, but a fix is still better than no fix at all, me thinks.

@SamuXarick SamuXarick force-pushed the SamuXarick:ai-gs-delete-query-string-child-window branch from 2030b9a to 292a517 Feb 20, 2019
@glx22
glx22 approved these changes Feb 21, 2019
@glx22 glx22 merged commit 66d23e3 into OpenTTD:master Feb 21, 2019
8 checks passed
8 checks passed
OpenTTD CI Build #20190220.27 succeeded
Details
OpenTTD CI (Linux commit-checker) Linux commit-checker succeeded
Details
OpenTTD CI (Linux linux-amd64-clang-3.8) Linux linux-amd64-clang-3.8 succeeded
Details
OpenTTD CI (Linux linux-amd64-gcc-6) Linux linux-amd64-gcc-6 succeeded
Details
OpenTTD CI (Linux linux-i386-gcc-6) Linux linux-i386-gcc-6 succeeded
Details
OpenTTD CI (MacOS) MacOS succeeded
Details
OpenTTD CI (Windows Win32) Windows Win32 succeeded
Details
OpenTTD CI (Windows Win64) Windows Win64 succeeded
Details
@SamuXarick SamuXarick deleted the SamuXarick:ai-gs-delete-query-string-child-window branch Mar 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.