Fix #7088: close AI/GS textfile window when their data are invalid

[SamuXarick]

… displaying a textfile

[LordAro]

Not a fan of this solution, it's too brittle. The issue boils down to the Window trying to maintain something consistent when the underlying state (the slot) changes.

Instead, the window should "save" the ScriptConfig object (GetConfig(slot)) in its constructor, and just refer to that from then on. Should help to fix a couple of the other recent issues (#7090, #7091) as well, I think...

[SamuXarick]

I added a solution based on OnInvalidateData, to complement the first. The only place I can think of that could alter the content of this window is via WC_AI_LIST (the window that lets me chose from a list of available AIs/GSs). So that's where it's called from at the moment.

[stale]

This pull request has been automatically marked as stale because it has not had any activity in the last month.
Please feel free to give a status update now, ping for review, or re-open when it's ready.
It will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

[SamuXarick]

For some reason, this fix stopped working properly. :(

EDIT: fixed it.

[stale]

This pull request has been automatically marked as stale because it has not had any activity in the last month.
Please feel free to give a status update now, ping for review, or re-open when it's ready.
It will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

[andythenorth]

Stale. Closing, thanks.

[SamuXarick]

ping for review

outdated

No more memory leak