Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Feature: Group liveries, and livery window usability enhancements. #7108
Company Colour defaults are now set like this:
For ungrouped trains, RVs etc, the long established (and weird imo) settings for some types of vehicle are kept. Note however that the checkboxes are now removed, reducing UI friction:
Liveries for groups do not offer settings by types of vehicle, 1CC and 2CC will be applied consistently to all vehicles in the group:
Group livery UI can also be opened directly from the groups window, with the correct group selected:
Looks good. I tested it and works as expected. But please run script/api/generate_widget.sh.
Ah yes. We really ought to make this part of the build process!
Hmm, sounds reasonable, although the title widget is already the company colour. EDIT Or not. Confused as I was testing something else and it was. EDIT And it is in master, just broken in this PR, wow.
Possibly depending on the next point.
This will change how setting a colour to 'Default' will work. Currently it means to fall back to the system of picking the colour based on the original liveries system. With hierarchy in place it would mean falling back to the parent scheme.
It's based on the extra OpenTTD GUI sprites that already exist, but there's no icon for 'choose colour'.
Well, instead of "Default", it should be "Inherited". But it is more consistent to inherit colour from parents, the same way autoreplacements work.
I think it is better to deal with this now for keeping commits to master in a better order.
@nielsmh Unless someone wants to improve them, I think the icons are fine.
Current version now displays the group hierarchy so the list order is the same as the group window, but does not affect how colour is assigned.
There's a small discrepancy anyway that when 'Default' is selected it shows the main company colour, but vehicles may not be that colour if the type-based liveries are used.