Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: grammar in translator intro notice #7124

Closed
wants to merge 1 commit into from
Closed

Conversation

@nikolas
Copy link
Member

@nikolas nikolas commented Jan 27, 2019

"signing up as translator" sounds kind of robotic, doesn't it?

"signing up as translator" sounds kind of robotic, doesn't it?
@nielsmh
Copy link
Contributor

@nielsmh nielsmh commented Jan 29, 2019

This string is already translated in every translation, except some of those in the "unfinished" directory. Nobody is ever going to see the English version. However, modifying the English version will invalidate all the existing translations on Eints, making pointless work to revalidate them all.

I'm against this change. The meaning of the text is sufficiently clear to be translated correctly.

@PeterN
Copy link
Member

@PeterN PeterN commented Jan 29, 2019

Agreed with @nielsmh

@PeterN PeterN closed this Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants