Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #6584: text layout problem in engine preview dialog #7132

Merged
merged 1 commit into from Jan 29, 2019

Conversation

@nikolas
Copy link
Member

@nikolas nikolas commented Jan 29, 2019

With language set to German, there was a problem in this dialog box due to the long strings in this language. It looks like the call to GetStringHeight() here is using r.top to help calculate the max width, rather than r.left.

Before this patch:
2019-01-28-215251_321x204_scrot

After:
2019-01-28-215405_324x205_scrot

With language set to German, there was a problem in this dialog box due
to the long strings in this language. It looks like the call to
`GetStringHeight()` here is using `r.top` to help calculate the
max width, rather than `r.left`.
@nikolas nikolas force-pushed the nikolas:increase-preview-win-width branch from cf36c9b to d219a7a Jan 29, 2019
@PeterN
PeterN approved these changes Jan 29, 2019
@PeterN PeterN merged commit 6a56a4c into OpenTTD:master Jan 29, 2019
1 check passed
1 check passed
OpenTTD CI Build #20190129.4 succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.