Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Make ships stop in locks to move up/down instead of following the slope. #7150

Merged
merged 1 commit into from Feb 4, 2019

Conversation

@PeterN
Copy link
Member

PeterN commented Jan 31, 2019

This needs some saveload conversion code.
It may also be desirable to make it a game setting.

Video of this in action: https://www.youtube.com/watch?v=sD4oOe-8Bk8

@PeterN PeterN added the wip label Jan 31, 2019
@planetmaker

This comment has been minimized.

Copy link
Contributor

planetmaker commented Jan 31, 2019

I like the idea very much. However I do not think we should introduce a setting for this (just convert old savegames to do the right thing [TM]).

@glx22

This comment has been minimized.

Copy link
Contributor

glx22 commented Jan 31, 2019

Oh nice, I like this behaviour, and as @planetmaker I don't think it needs a setting. It's similar to the ship slow rotate you added recently.

src/ship_cmd.cpp Outdated Show resolved Hide resolved
src/ship_cmd.cpp Outdated Show resolved Hide resolved
@PeterN PeterN force-pushed the PeterN:locks branch from b3045e9 to fddc11d Feb 1, 2019
src/saveload/afterload.cpp Outdated Show resolved Hide resolved
@PeterN PeterN force-pushed the PeterN:locks branch from fddc11d to 299a09c Feb 1, 2019
src/ship_cmd.cpp Outdated Show resolved Hide resolved
@PeterN PeterN force-pushed the PeterN:locks branch from 9d9f76d to e1214aa Feb 2, 2019
@PeterN PeterN removed the wip label Feb 2, 2019
@PeterN PeterN force-pushed the PeterN:locks branch from e1214aa to faeb512 Feb 2, 2019
@LordAro
LordAro approved these changes Feb 4, 2019
@LordAro LordAro merged commit 0b10678 into OpenTTD:master Feb 4, 2019
1 check passed
1 check passed
OpenTTD CI Build #20190202.19 succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.