Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upChange: Make ships stop in locks to move up/down instead of following the slope. #7150
+90
−1
Conversation
PeterN
added
the
wip
label
Jan 31, 2019
This comment has been minimized.
This comment has been minimized.
|
I like the idea very much. However I do not think we should introduce a setting for this (just convert old savegames to do the right thing [TM]). |
This comment has been minimized.
This comment has been minimized.
|
Oh nice, I like this behaviour, and as @planetmaker I don't think it needs a setting. It's similar to the ship slow rotate you added recently. |
J0anJosep
reviewed
Jan 31, 2019
src/ship_cmd.cpp Outdated
J0anJosep
reviewed
Jan 31, 2019
src/ship_cmd.cpp Outdated
PeterN
force-pushed the
PeterN:locks
branch
from
b3045e9
to
fddc11d
Feb 1, 2019
PeterN
reviewed
Feb 1, 2019
src/saveload/afterload.cpp Outdated
PeterN
force-pushed the
PeterN:locks
branch
from
fddc11d
to
299a09c
Feb 1, 2019
J0anJosep
reviewed
Feb 1, 2019
src/ship_cmd.cpp Outdated
PeterN
force-pushed the
PeterN:locks
branch
from
9d9f76d
to
e1214aa
Feb 2, 2019
PeterN
removed
the
wip
label
Feb 2, 2019
PeterN
force-pushed the
PeterN:locks
branch
from
e1214aa
to
faeb512
Feb 2, 2019
LordAro
approved these changes
Feb 4, 2019
LordAro
merged commit 0b10678
into
OpenTTD:master
Feb 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
PeterN commentedJan 31, 2019
This needs some saveload conversion code.
It may also be desirable to make it a game setting.
Video of this in action: https://www.youtube.com/watch?v=sD4oOe-8Bk8