Change: Make ships stop in locks to move up/down instead of following the slope. #7150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterN
added
the
wip
|
I like the idea very much. However I do not think we should introduce a setting for this (just convert old savegames to do the right thing [TM]). |
|
Oh nice, I like this behaviour, and as @planetmaker I don't think it needs a setting. It's similar to the ship slow rotate you added recently. |
J0anJosep
reviewed
Jan 31, 2019
J0anJosep
reviewed
Jan 31, 2019
PeterN
reviewed
Feb 1, 2019
J0anJosep
reviewed
Feb 1, 2019
PeterN
removed
the
wip
LordAro
approved these changes
Feb 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This needs some saveload conversion code.
It may also be desirable to make it a game setting.
Video of this in action: https://www.youtube.com/watch?v=sD4oOe-8Bk8