Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Make ships stop in locks to move up/down instead of following the slope. #7150

Merged
merged 1 commit into from Feb 4, 2019

Conversation

PeterN
Copy link
Member

@PeterN PeterN commented Jan 31, 2019

This needs some saveload conversion code.
It may also be desirable to make it a game setting.

Video of this in action: https://www.youtube.com/watch?v=sD4oOe-8Bk8

@PeterN PeterN added the wip label Jan 31, 2019
@planetmaker
Copy link
Contributor

@planetmaker planetmaker commented Jan 31, 2019

I like the idea very much. However I do not think we should introduce a setting for this (just convert old savegames to do the right thing [TM]).

@glx22
Copy link
Contributor

@glx22 glx22 commented Jan 31, 2019

Oh nice, I like this behaviour, and as @planetmaker I don't think it needs a setting. It's similar to the ship slow rotate you added recently.

src/ship_cmd.cpp Outdated Show resolved Hide resolved
src/ship_cmd.cpp Outdated Show resolved Hide resolved
src/saveload/afterload.cpp Outdated Show resolved Hide resolved
src/ship_cmd.cpp Outdated Show resolved Hide resolved
@PeterN PeterN removed the wip label Feb 2, 2019
LordAro
LordAro approved these changes Feb 4, 2019
@LordAro LordAro merged commit 0b10678 into OpenTTD:master Feb 4, 2019
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants