Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset ai gs non anchored settings #7167

Conversation

SamuXarick
Copy link
Contributor

@SamuXarick SamuXarick commented Feb 3, 2019

No description provided.

@SamuXarick
Copy link
Contributor Author

@SamuXarick SamuXarick commented Feb 3, 2019

I'm not too happy with this fix. The problem is deeper than it looks.

https://gist.github.com/SamuXarick/80b449c63b2b752cc8fa1dfd9e668596

Also enables the Reset button while in-game for AI configs.
@SamuXarick SamuXarick force-pushed the reset-ai-gs-non-anchored-settings branch from bed9623 to c79521d Compare Mar 1, 2019
@TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Mar 2, 2019

From my understanding, you yourself consider this a draft PR. Please open up a new PR if you are happy with your fix. And please explain in the PR what you are trying to fix, as that is lacking atm :)

@TrueBrain TrueBrain closed this Mar 2, 2019
@SamuXarick
Copy link
Contributor Author

@SamuXarick SamuXarick commented Mar 2, 2019

From my understanding, you yourself consider this a draft PR. Please open up a new PR if you are happy with your fix. And please explain in the PR what you are trying to fix, as that is lacking atm :)

No, the fix itself is fine, the problem doesn't come from the fix, but the underlying issue, the inconsistency of what is configurable under different situations, or the issues that may originate from them.

I posted a gist with what I think are the expected behaviours under those situations. But I quickly came to realise it needs to have a consistent rule structure, usable throughout the entire ai_gui.cpp file. Something that I've already done on #7084

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants