Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: CompanyEconomy documentation #7168

Merged
merged 1 commit into from Feb 12, 2019
Merged

Fix: CompanyEconomy documentation #7168

merged 1 commit into from Feb 12, 2019

Conversation

@ThomasdenH
Copy link
Contributor

@ThomasdenH ThomasdenH commented Feb 3, 2019

Company income was described as an unsigned integer, but it should be signed.

Copy link
Member

@michicc michicc left a comment

Unfortunately, your commit messages trips the automated checker.

You need a : after the Fix, i.e. Fix: CompanyEconomy documentation. Amend your commit and force-push the changed commit (GitHub handles forced pushes just fine).

@ThomasdenH
Copy link
Contributor Author

@ThomasdenH ThomasdenH commented Feb 3, 2019

Sadly to preserve alignment this PR isn't quite one character. Maybe the commit message can be fixed by a rebase?

@michicc
Copy link
Member

@michicc michicc commented Feb 3, 2019

It has to be fixed with a rebase (and the second commit should be squashed into the first at the same time). No merge unless the CI check is green.

@PeterN
Copy link
Member

@PeterN PeterN commented Feb 3, 2019

Just use git commit --amend and then force push.

Company income was described as an unsigned integer, but it should be signed.
@ThomasdenH
Copy link
Contributor Author

@ThomasdenH ThomasdenH commented Feb 11, 2019

I have edited the commit message.

@ThomasdenH ThomasdenH changed the title Fix CompanyEconomy documentation Fix: CompanyEconomy documentation Feb 11, 2019
@LordAro LordAro merged commit 412e613 into OpenTTD:master Feb 12, 2019
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants