Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Spectator color #7169

Closed
wants to merge 1 commit into from
Closed

Conversation

@SamuXarick
Copy link
Contributor

SamuXarick commented Feb 3, 2019

unnamed 2002-01-06

@PeterN
Copy link
Member

PeterN commented Feb 3, 2019

This is wrong, it should be uncoloured so that when not highlighted, it stays black.

@nielsmh
Copy link
Contributor

nielsmh commented Feb 3, 2019

Is this really correct? Shouldn't it have no colour code at all instead? Most other menus have black text when normal, and white text when highlighted. The exceptions are Client list and Spectate in the Companies menu in multiplayer.

image
image

@nielsmh
Copy link
Contributor

nielsmh commented Feb 3, 2019

In fact, shouldn't it say "Global goals" rather than Spectator? Since they're not the goals for the spectators, but the goals for everyone.

Copy link
Contributor

nielsmh left a comment

Per the above comments, this is the wrong fix.

@SamuXarick SamuXarick closed this Feb 16, 2019
@SamuXarick SamuXarick deleted the SamuXarick:white-spectator branch Feb 16, 2019
@SamuXarick SamuXarick restored the SamuXarick:white-spectator branch Feb 16, 2019
@SamuXarick SamuXarick reopened this Feb 16, 2019
@SamuXarick SamuXarick closed this Feb 16, 2019
@SamuXarick SamuXarick deleted the SamuXarick:white-spectator branch Feb 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.