Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upCodechange: making the style of MakeVoid calls uniform #7192
Conversation
Good in principle, though I'm not a fan of the I'd recommend looking for other potential uses of Oh, and the commit should be |
This comment has been minimized.
This comment has been minimized.
@@ -995,8 +995,8 @@ void GenerateTerrainPerlin() | |||
|
|||
/* First make sure the tiles at the north border are void tiles if needed. */ | |||
if (_settings_game.construction.freeform_edges) { | |||
for (int y = 0; y < _height_map.size_y - 1; y++) MakeVoid(_height_map.size_x * y); | |||
for (int x = 0; x < _height_map.size_x; x++) MakeVoid(x); |
This comment has been minimized.
This comment has been minimized.
LordAro
Feb 8, 2019
Member
seems to me like _height_map could go away entirely, but that's for another time :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
GabdaZM commentedFeb 7, 2019
•
edited
Started form making
sizex * y + x
intoTileXY(x, y)
.