Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upReplace Window::scrolling_scrollbar with Window::mouse_capture_widget #7227
Conversation
|
No issues, with the exception of the active_widget rename |
PeterN
changed the title
|
Variable has been renamed :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
PeterN commentedFeb 14, 2019
•
edited
This allows us to support generic widget scrolling/dragging. Scrollbars are now handled by testing that the widget type is
NWID_VSCROLLBARorNWID_HSCROLLBAR, otherwise anOnClick()event is dispatched to the window withclick_countof zero (logically no additional clicks have been made).This is followed up by setting
mouse_capture_widgetwhen dragging a music window volume slider, see #7209 for reference.And for completeness, click-left dragging the smallmap is improved (and matches right-click dragging behaviour) by setting
mouse_capture_widget.