Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Decrease the min #opcodes #7243

Merged
merged 1 commit into from Feb 28, 2019
Merged

Change: Decrease the min #opcodes #7243

merged 1 commit into from Feb 28, 2019

Conversation

@SamuXarick
Copy link
Contributor

SamuXarick commented Feb 18, 2019

No description provided.

@LordAro
Copy link
Member

LordAro commented Feb 21, 2019

Please explain the reasoning behind this PR. Why is it necessary?

@SamuXarick
Copy link
Contributor Author

SamuXarick commented Feb 23, 2019

It was an idea to help maintaining 33 fps with 15 AIs on 4096x4096 maps. Less max opcodes would help, but it would also make the AIs look rather innactive most of the time. I guess I just wanted to be able to insert a lower value than 5000 to see what it would look like.

@Moth-Tolias
Copy link

Moth-Tolias commented Feb 23, 2019

perhaps making this a configurable option would be possible?

@PeterN
Copy link
Member

PeterN commented Feb 23, 2019

That's rather meta. A config option to set the minimum value of a config option...

@Moth-Tolias
Copy link

Moth-Tolias commented Feb 23, 2019

oh, gosh. I really should have focused a little more carefully while reading - sorry about that!

Copy link
Member

LordAro left a comment

Don't see why not, it's not changing default after all.
Perhaps the helptext could be updated to more clearly indicate that a lower number would slow AIs down ?

@PeterN PeterN merged commit 0326405 into OpenTTD:master Feb 28, 2019
8 checks passed
8 checks passed
OpenTTD CI Build #20190218.7 succeeded
Details
OpenTTD CI (Linux commit-checker) Linux commit-checker succeeded
Details
OpenTTD CI (Linux linux-amd64-clang-3.8) Linux linux-amd64-clang-3.8 succeeded
Details
OpenTTD CI (Linux linux-amd64-gcc-6) Linux linux-amd64-gcc-6 succeeded
Details
OpenTTD CI (Linux linux-i386-gcc-6) Linux linux-i386-gcc-6 succeeded
Details
OpenTTD CI (MacOS) MacOS succeeded
Details
OpenTTD CI (Windows Win32) Windows Win32 succeeded
Details
OpenTTD CI (Windows Win64) Windows Win64 succeeded
Details
@SamuXarick SamuXarick deleted the SamuXarick:min-opcodes branch Mar 1, 2019
nielsmh added a commit to nielsmh/OpenTTD that referenced this pull request Mar 11, 2019
douiwby added a commit to douiwby/OpenTTD that referenced this pull request Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.