Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove: OPF #7245

Merged
merged 2 commits into from Mar 16, 2019
Merged

Remove: OPF #7245

merged 2 commits into from Mar 16, 2019

Conversation

@LordAro
Copy link
Member

LordAro commented Feb 18, 2019

A solution to all the complaints about it being broken and different

@LordAro LordAro force-pushed the LordAro:opfbyebye branch 3 times, most recently from fce8593 to a811ac6 Feb 18, 2019
@James103
Copy link
Contributor

James103 commented Feb 19, 2019

I agree in that the original pathfinder was buggy, caused a lot of lag, and was frustrating for some. However, the setting migration needs to be handled. What I think should happen when migrating the pathfinder settings is that if the old setting resolved to the original pathfinder, then on conversion, the setting to change to whatever the default is. NPF stays as NPF and YAPF stays as YAPF. Therefore, if OPF then YAPF, if NPF then NPF, and if YAPF then YAPF.

@PeterN
Copy link
Member

PeterN commented Feb 19, 2019

By default an invalid setting should be set to the default, so this should not be a concern.

@LordAro LordAro force-pushed the LordAro:opfbyebye branch from a811ac6 to e9560fc Feb 23, 2019
@nielsmh nielsmh added this to the 1.10.0 milestone Feb 27, 2019
@LordAro LordAro force-pushed the LordAro:opfbyebye branch from e9560fc to 639ad1c Mar 10, 2019
@PeterN
PeterN approved these changes Mar 16, 2019
@PeterN PeterN merged commit 592f591 into OpenTTD:master Mar 16, 2019
8 checks passed
8 checks passed
OpenTTD CI Build #20190310.25 succeeded
Details
OpenTTD CI (Linux commit-checker) Linux commit-checker succeeded
Details
OpenTTD CI (Linux linux-amd64-clang-3.8) Linux linux-amd64-clang-3.8 succeeded
Details
OpenTTD CI (Linux linux-amd64-gcc-6) Linux linux-amd64-gcc-6 succeeded
Details
OpenTTD CI (Linux linux-i386-gcc-6) Linux linux-i386-gcc-6 succeeded
Details
OpenTTD CI (MacOS) MacOS succeeded
Details
OpenTTD CI (Windows Win32) Windows Win32 succeeded
Details
OpenTTD CI (Windows Win64) Windows Win64 succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.