Fix #7189: Fluidsynth volume gain too high #7253
Merged
Conversation
I'm impressed the gain range for fluidsynth is 0.0 to 10.0, default is 0.2, and anything above that easily causes clipping. Would it be too much to ask to make it a configurable setting for the music driver, similar to how the Win32 and DMusic drivers allows selecting a MIDI port? Users would only be able to configure it via commandline or editing the ini file, but still an option for advanced users who may be using a different sound font with different volume characteristics. |
Can't see anything straight up wrong with this. If anyone complains about too low volume we can implement a configuration for max gain at that time. |
Let me be the one to complain about low volume. The music is way too soft compared to sound effects at this level. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
No description provided.