Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #7003: Freetype fonts were scaled by both GUI and Font zoom levels. #7267

Merged
merged 2 commits into from Feb 23, 2019

Conversation

@PeterN
Copy link
Member

@PeterN PeterN commented Feb 23, 2019

No description provided.

@PeterN PeterN requested a review from LordAro Feb 23, 2019
@nielsmh
Copy link
Contributor

@nielsmh nielsmh commented Feb 23, 2019

This breaks the font size setting with True Type fonts.

image

Only the bitmap symbols in station signs have been scaled, the TT font has not.

@PeterN
Copy link
Member Author

@PeterN PeterN commented Feb 23, 2019

That... works fine for me. What? EDIT Ah, I know why...

@PeterN
Copy link
Member Author

@PeterN PeterN commented Feb 23, 2019

So there is an issue now that throughout the windows they tend to be scaling by gui zoom level, but some times it should now been by font zoom level instead. Or possibly both in a single widget... Seems a wide scope :/

@nielsmh
Copy link
Contributor

@nielsmh nielsmh commented Feb 23, 2019

It should be enough to update the FONT_HEIGHT_NORMAL etc. macros, but maybe the result of those are scaled by the GUI size too? (I would think they shouldn't be.)

@PeterN
Copy link
Member Author

@PeterN PeterN commented Feb 23, 2019

I'm mistaken, these issues already existed, just it's easier to see now that it's very easy to use a massive font. These two commits solve the issue in the PR title.

@PeterN PeterN merged commit eeae451 into OpenTTD:master Feb 23, 2019
8 checks passed
@PeterN PeterN deleted the fix-7003 branch Feb 23, 2019
nielsmh added a commit to nielsmh/OpenTTD that referenced this issue Mar 11, 2019
douiwby added a commit to douiwby/OpenTTD that referenced this issue Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants