Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: [NPF] Add path cache for ships. #7272

Closed
wants to merge 1 commit into from

Conversation

J0anJosep
Copy link
Contributor

@J0anJosep J0anJosep commented Feb 24, 2019

Trying to extend cached paths to ships and NPF.

I know const_cast is not a good way of doing it, but I don't have time to remove it now. If it is necessary, maybe in a few weeks...

@PeterN
Copy link
Member

PeterN commented Mar 3, 2019

Yes, const cast probably needs to go.

@J0anJosep
Copy link
Contributor Author

J0anJosep commented Mar 3, 2019

const_cast removed
I am not satisfied with this solution either.

@PeterN
Copy link
Member

PeterN commented Mar 7, 2019

Is this working? I'm not noticing any performance improvement.

EDIT: I think it's a difference in how no path found is handled between YAPF and NPF.

@J0anJosep
Copy link
Contributor Author

J0anJosep commented Mar 7, 2019

If you provide a savegame, I will look into it.

@stale
Copy link

stale bot commented Apr 6, 2019

This pull request has been automatically marked as stale because it has not had any activity in the last month.
Please feel free to give a status update now, ping for review, or re-open when it's ready.
It will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@stale stale bot added the stale Stale issues label Apr 6, 2019
@stale stale bot closed this Apr 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Stale issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants