Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #7274, Fix #7043: Town bridges store town indexes in map array. #7282

Conversation

@SamuXarick
Copy link
Contributor

SamuXarick commented Feb 26, 2019

This also addresses the source of the stalls of #7274.

This patch is assuming that towns that generated with 0 population didn't build any bridges. It may not be correct. Needs better investigation.

@SamuXarick SamuXarick force-pushed the SamuXarick:dont-remove-bridges-when-generating-world branch from de08a20 to 679175c Feb 26, 2019
@SamuXarick SamuXarick force-pushed the SamuXarick:dont-remove-bridges-when-generating-world branch from 679175c to d0184df Feb 26, 2019
@SamuXarick SamuXarick changed the title Fix #7274 #7043: Don't remove bridges when generating towns with 0 population Fix #7274, Fix #7043: Don't remove bridges when generating towns with 0 population Feb 26, 2019
@PeterN

This comment has been minimized.

Copy link
Member

PeterN commented Feb 26, 2019

You can change the assumption by adding a test at the top of GrowTownWithBridge() to ensure that no bridges are built when the population is 0.

@SamuXarick SamuXarick changed the title Fix #7274, Fix #7043: Don't remove bridges when generating towns with 0 population Fix #7274, Fix #7043: Town bridges store town indexes in map array. Feb 27, 2019
docs/landscape.html Outdated Show resolved Hide resolved
SamuXarick added 2 commits Feb 27, 2019
@TrueBrain TrueBrain added this to the 1.10.0 milestone Mar 3, 2019
@SamuXarick SamuXarick closed this Mar 3, 2019
@SamuXarick SamuXarick deleted the SamuXarick:dont-remove-bridges-when-generating-world branch Mar 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.