Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Allow vehicle group names to be non-unique. #7287

Merged
merged 1 commit into from Mar 3, 2019

Conversation

PeterN
Copy link
Member

@PeterN PeterN commented Feb 26, 2019

Group names are visual identifiers, and do not need to be unique.

Group sorting already falls back to group ID if names are the same, so that sorted
list position is stable.

Group names are visual identifiers, and do not need to be unique.
Group sorting already falls back to group ID if names are the same, so that sorted
list position is stable.
@J0anJosep
Copy link
Contributor

@J0anJosep J0anJosep commented Feb 26, 2019

Yet group names do not need to be unique, it would be strange if someone had a list of all groups named "Passengers".

I wrote a patch similar to this one some time ago, allowing more freedom naming groups but keeping uniqueness under same VehicleType and Owner. I thought it would be an improvement, but never thought any official developer would take it seriously.

@PeterN
Copy link
Member Author

@PeterN PeterN commented Feb 26, 2019

Enforcing uniqueness may become annoying when you want to make use of group hierarchy, where you may want to name sub-groups based on their location, cargo types, or similar.

@PeterN PeterN added this to the 1.9.0 milestone Feb 28, 2019
@PeterN PeterN requested a review from LordAro Feb 28, 2019
@nielsmh nielsmh merged commit c91e005 into OpenTTD:master Mar 3, 2019
8 checks passed
@PeterN PeterN deleted the allow-duplicate-group-names branch May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants