Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 23960d0f2c: Company livery window shows incorrect groups when opened from group window in multiplayer. #7288

Merged
merged 1 commit into from Mar 3, 2019

Conversation

PeterN
Copy link
Member

@PeterN PeterN commented Feb 26, 2019

No description provided.

@nielsmh nielsmh added this to the 1.9.0 milestone Feb 27, 2019
@PeterN PeterN added the bug label Feb 28, 2019
@PeterN PeterN requested review from LordAro and michicc Feb 28, 2019
@nielsmh
Copy link
Contributor

@nielsmh nielsmh commented Mar 3, 2019

I'm not sure I understand how to reproduce this bug.

@PeterN
Copy link
Member Author

@PeterN PeterN commented Mar 3, 2019

As a client on a server, and not company 0, create a vehicle group and click on the group livery button within that window. The licery window will open with the wrong groups.

@nielsmh
Copy link
Contributor

@nielsmh nielsmh commented Mar 3, 2019

Here's what I do:

  1. Start a multiplayer game, join with an extra client.
  2. As company 1, build a road vehicle and put it in a named group.
  3. As company 2, build a road vehicle and put it in a differently named group.
  4. As company 2, open own road vehicles list, select the group, click the Group Livery button below groups list.

What happens: Company 2 livery window opens showing company 2 group names.

What I understand you describing happens: Company 1 group names are shown in company 2 livery window.

@PeterN
Copy link
Member Author

@PeterN PeterN commented Mar 3, 2019

Might not always occur then. I think andy reported it and i coukd reproduce.

Copy link
Member

@TrueBrain TrueBrain left a comment

Can reproduce it with the steps above, and with this PR applied I can no longer. Doesn't mean a lot, but at least it does something :D

@TrueBrain TrueBrain merged commit 93a6fd4 into OpenTTD:master Mar 3, 2019
8 checks passed
@PeterN PeterN deleted the company-livery-window-fix branch Mar 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants