Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: No need to save AI/GS data when joining a multiplayer server #7292

Closed
wants to merge 1 commit into from

Conversation

@SamuXarick
Copy link
Contributor

SamuXarick commented Feb 28, 2019

@@ -63,6 +63,7 @@ SaveLoadVersion _sl_version; ///< the major savegame version identifier
byte _sl_minor_version; ///< the minor savegame version, DO NOT USE!
char _savegame_format[8]; ///< how to compress savegames
bool _do_autosave; ///< are we doing an autosave at the moment?
bool _save_empty_script; ///< are we sending a map to a client over the nework?

This comment has been minimized.

Copy link
@PeterN

PeterN Feb 28, 2019

Member

Comment and variable name are... what?

@@ -281,7 +282,7 @@

/* static */ void AI::Save(CompanyID company)
{
if (!_networking || _network_server) {
if (!_networking || _network_server && !_save_empty_script) {

This comment has been minimized.

Copy link
@PeterN

PeterN Feb 28, 2019

Member

Additional parenthesis required.

@SamuXarick SamuXarick force-pushed the SamuXarick:save-empty-script branch from 494afaf to 787116d Feb 28, 2019
@TrueBrain

This comment has been minimized.

Copy link
Member

TrueBrain commented Mar 2, 2019

Okay, correct me if I am wrong:
In 2016 you tried this PR, and it got declined with: this PR is fixing the wrong issue.
Without any argumentation why things are different now, you file the exact same PR again. I see no reason to not close it with the same argumentation.

In general, it is very impolite to try the same thing again, expecting a different outcome, without arguing your case. Please consider making your case, instead of just trying again.

@TrueBrain TrueBrain closed this Mar 2, 2019
@SamuXarick

This comment has been minimized.

Copy link
Contributor Author

SamuXarick commented Mar 2, 2019

Because clients do not load AI/GS.

if (_networking && !_network_server) {
if (Company::IsValidAiID(index)) AIInstance::LoadEmpty();
continue;
}

if (_networking && !_network_server) {
GameInstance::LoadEmpty();
if ((CompanyID)SlIterateArray() != (CompanyID)-1) SlErrorCorrupt("Too many GameScript configs");
return;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.