Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Always report error when ordering a road vehicle to wrong type of road stop. #7316

Merged
merged 1 commit into from Apr 13, 2019

Conversation

@PeterN
Copy link
Member

PeterN commented Mar 3, 2019

Currently trying to order an articulated truck to a bus stop does nothing, but ordering it to a non-drive-through stop gives an error. This change makes both cases return an error.

Ordering to stops of different transport types is still ignored.

@PeterN

This comment has been minimized.

Copy link
Member Author

PeterN commented Mar 3, 2019

Hmm, the behaviour of this might be dependent on the quick orders setting.

@PeterN PeterN added the needs review label Mar 7, 2019
@michicc

This comment has been minimized.

Copy link
Member

michicc commented Mar 30, 2019

Needs rebase to get a review.

@TrueBrain

This comment has been minimized.

Copy link
Member

TrueBrain commented Apr 13, 2019

Kind reminder this is waiting on author :)

@PeterN PeterN force-pushed the PeterN:order-wrong-stop-type branch from 66a0286 to 18cd70c Apr 13, 2019
@PeterN

This comment has been minimized.

Copy link
Member Author

PeterN commented Apr 13, 2019

No longer waiting on me.

Copy link
Member

TrueBrain left a comment

Possibly a 'fix' instead of a 'change' :)

@PeterN PeterN merged commit b9b34f6 into OpenTTD:master Apr 13, 2019
8 checks passed
8 checks passed
OpenTTD CI Build #20190413.2 succeeded
Details
OpenTTD CI (Linux commit-checker) Linux commit-checker succeeded
Details
OpenTTD CI (Linux linux-amd64-clang-3.8) Linux linux-amd64-clang-3.8 succeeded
Details
OpenTTD CI (Linux linux-amd64-gcc-6) Linux linux-amd64-gcc-6 succeeded
Details
OpenTTD CI (Linux linux-i386-gcc-6) Linux linux-i386-gcc-6 succeeded
Details
OpenTTD CI (MacOS) MacOS succeeded
Details
OpenTTD CI (Windows Win32) Windows Win32 succeeded
Details
OpenTTD CI (Windows Win64) Windows Win64 succeeded
Details
@PeterN PeterN deleted the PeterN:order-wrong-stop-type branch Apr 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.