Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Always report error when ordering a road vehicle to wrong type of road stop. #7316

Merged
merged 1 commit into from Apr 13, 2019

Conversation

PeterN
Copy link
Member

@PeterN PeterN commented Mar 3, 2019

Currently trying to order an articulated truck to a bus stop does nothing, but ordering it to a non-drive-through stop gives an error. This change makes both cases return an error.

Ordering to stops of different transport types is still ignored.

@PeterN
Copy link
Member Author

@PeterN PeterN commented Mar 3, 2019

Hmm, the behaviour of this might be dependent on the quick orders setting.

@michicc
Copy link
Member

@michicc michicc commented Mar 30, 2019

Needs rebase to get a review.

@TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Apr 13, 2019

Kind reminder this is waiting on author :)

@PeterN
Copy link
Member Author

@PeterN PeterN commented Apr 13, 2019

No longer waiting on me.

Copy link
Member

@TrueBrain TrueBrain left a comment

Possibly a 'fix' instead of a 'change' :)

@PeterN PeterN merged commit b9b34f6 into OpenTTD:master Apr 13, 2019
8 checks passed
@PeterN PeterN deleted the order-wrong-stop-type branch Apr 13, 2019
douiwby pushed a commit to douiwby/OpenTTD that referenced this issue Apr 16, 2020
…e of road stop. (OpenTTD#7316)

This was inconsistent before, depending on road/tram and articulated/single vehicle status.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants