Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #7308: MinGW build with SDL #7318

Merged
merged 3 commits into from Mar 3, 2019
Merged

Fix #7308: MinGW build with SDL #7318

merged 3 commits into from Mar 3, 2019

Conversation

LordAro
Copy link
Member

@LordAro LordAro commented Mar 3, 2019

And also static build with SDL generally. And a zlib variable that was wrong

@LordAro LordAro requested a review from TrueBrain Mar 3, 2019
@LordAro LordAro added this to the 1.9.0 milestone Mar 3, 2019
Copy link
Member

@TrueBrain TrueBrain left a comment

Can you please make 3 commits out of this? Otherwise it is very annoying in the history to see what was going on ;) Especially as things turn out to be unwanted .. like I am unsure if we want to change 'static-libs' into '--libs --static'. And the zlib-config thing is weird, as if this doesn't work, it should constantly complain. You have me confused by bringing more to the table than suggested ;)

@LordAro LordAro merged commit 4ac81b3 into OpenTTD:master Mar 3, 2019
8 checks passed
@LordAro LordAro deleted the fix-mingw-sdl branch Mar 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants