Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MorphOS / AmigaOS / BeOS support and libtimidity support #7326

Merged
merged 4 commits into from Mar 5, 2019

Conversation

@TrueBrain
Copy link
Member

TrueBrain commented Mar 4, 2019

Every commit explains why that part is being removed. In summary:

If #7086 drops, MorphOS / AmigaOS are no longer supported, and BeOS is suggested to upgrade to Haiku.
libtimidity was a PSP only music driver, which we forgot to remove when we dropped PSP.
NDS is NintendoDS, which had some leftovers from whenever.

TrueBrain added 4 commits Mar 4, 2019
In 10 years there is no commit to change how MorphOS works, and we
have no active maintainer for it. It is unlikely it works in its
current state (but not impossible).

With the arrival of SDL2 (and removal of SDL), MorphOS is no longer
support. There is an SDL2 port for MorphOS, but it is not maintained
by upstream SDL2, and nobody can currently test it out.

If anyone wants to re-add MorphOS, please do (revert this patch,
fix the problems, and create a Pull Request). If you need any help
doing so, let us know! It is not that we don't like MorphOS, it is
that we don't have anyone fixing the problems :(
In 10 years there is no commit to change how BeOS works, and we
have no active maintainer for it. It is unlikely it works in its
current state (but not impossible).

With the arrival of SDL2 (and removal of SDL), BeOS is no longer
support. SDL2 suggests to use Haiku instead of BeOS.
libtimidity was introduced with the support for PSP. PSP has been
dropped almost a year ago, but this music driver was not. This
corrects that oversight.

timidity (via extmidi) still works fine. This purely removes the
libtimidity support, which was only really available for PSP.
@TrueBrain TrueBrain force-pushed the TrueBrain:remove_beos_morphos branch from b0aa793 to f1a298c Mar 4, 2019
@michicc
michicc approved these changes Mar 5, 2019
@TrueBrain TrueBrain merged commit aa35052 into OpenTTD:master Mar 5, 2019
8 checks passed
8 checks passed
OpenTTD CI Build #20190304.12 succeeded
Details
OpenTTD CI (Linux commit-checker) Linux commit-checker succeeded
Details
OpenTTD CI (Linux linux-amd64-clang-3.8) Linux linux-amd64-clang-3.8 succeeded
Details
OpenTTD CI (Linux linux-amd64-gcc-6) Linux linux-amd64-gcc-6 succeeded
Details
OpenTTD CI (Linux linux-i386-gcc-6) Linux linux-i386-gcc-6 succeeded
Details
OpenTTD CI (MacOS) MacOS succeeded
Details
OpenTTD CI (Windows Win32) Windows Win32 succeeded
Details
OpenTTD CI (Windows Win64) Windows Win64 succeeded
Details
@TrueBrain TrueBrain deleted the TrueBrain:remove_beos_morphos branch Mar 5, 2019
@mikrosk
Copy link

mikrosk commented Apr 2, 2020

If #7086 drops

If may I ask, does this mean that SDL1 support is on its way to be removed?

@LordAro
Copy link
Member

LordAro commented Apr 2, 2020

Probably not any time soon, but since SDL2 is well established at this point, I wouldn't want to suggest that the SDL1 driver will be around forever

@nielsmh
Copy link
Contributor

nielsmh commented Apr 2, 2020

I wanted to keep the SDL1 driver as an alternative until we're sure the SDL2 driver is at least as good/reliable, it's probably staying around for at least one more year.

@mikrosk
Copy link

mikrosk commented Apr 2, 2020

Thanks for reply, guys. I ask because I'm the mysterious author of the unofficial Atari port mentioned here: https://www.tt-forums.net/viewtopic.php?t=83077 ... and we rely on SDL1 quite heavily, there is no point of having SDL2 ported to our platform.

I know, I know, I should have ported it back to upstream, shame on me! If that move would motivate you to keep SDL1 support in OpenTTD, perhaps it's time I'll take a look at OpenTTD again. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.