Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upFeature: Improve restart command #7328
Conversation
This comment has been minimized.
This comment has been minimized.
I'm not sure I would expect |
This comment has been minimized.
This comment has been minimized.
I think such makes sense for competitive servers which re-run the same scenario. Could be argued that 'restart' generates a new map with current newgame settings while 'reload' restarts the currently loaded map / savegame. |
This comment has been minimized.
This comment has been minimized.
Yes, a |
This comment has been minimized.
This comment has been minimized.
Here's what i intuitively would think
but don't do anything special with savegames. |
This comment has been minimized.
This comment has been minimized.
That would mean, a reference to the original scenario/heightmap must be stored in savegames, and this reference must still work if the file was moved (fallback to 2. if it was not found) |
This comment has been minimized.
This comment has been minimized.
How about the Quake approach - have a variable/setting containing a console command to execute on game end? That command could be a simple |
This comment has been minimized.
This comment has been minimized.
i don't see how that has anything to do with the topic being discussed. this is about what the |
This comment has been minimized.
This comment has been minimized.
At the moment, in trunk, if you use Hence, I don't understand your |
This comment has been minimized.
This comment has been minimized.
Why would you make savegames stand out? Savegames and scenarios are kind of the same resource. To me they are interchangeable. |
This comment has been minimized.
This comment has been minimized.
they might be interchangable on a technical level, but not really at a logical/usage level.
you could make that savegame into a scenario, then start from that scenario. but what about the reverse? what if you loaded a backup savegame because of some griefers that messed everything up? you'd restart from that instead of the original one in your way. |
This comment has been minimized.
This comment has been minimized.
It is true I got carried away by the technical level, as I did not have a point of reference for semantics in OpenTTD. Savegames & scenarios are literally the same, except the former did not necessarily come from the editor... I made some changes to only intercept savegames in editor mode. Would that be satisfactory? |
0e6a350
to
e13ac77
This comment has been minimized.
This comment has been minimized.
stale
bot
commented
Apr 5, 2019
This pull request has been automatically marked as stale because it has not had any activity in the last month. |
This comment has been minimized.
This comment has been minimized.
Ping? |
2c26cfc
to
4b2718f
When the restart command is issued, a normal map is always spawned. This improvement takes into account the current state of _file_to_saveload to check if a savegame/scenario/heightmap was previously loaded, and loads the same resource again.
Berbe commentedMar 5, 2019
•
edited
When the
restart
command is issued, a normal map is always spawned.This improvement takes into account the current state of
_file_to_saveload
to check if a savegame/scenario/heightmap was previously loaded, and loads the same resource again.