Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Add pid, file, line number & function/procedure name to debug messages #7350

Closed
wants to merge 1 commit into from

Conversation

@Berbe
Copy link
Contributor

Berbe commented Mar 9, 2019

Using added information helps pinpointing where information comes from, especially when tracing function/procedure use or getting a global picture of deep/recursive calls.

However, unlike timestamp, there is no existing option to rely on to make this addition conditional, which might be somewhat wished, as the addition make debug lines way longer than before.

  1. Making that unconditional (as it is)?
  2. Making that conditional, using the timestamp option?
  3. Making that condition, creating a new option?
@Berbe

This comment has been minimized.

Copy link
Contributor Author

Berbe commented Mar 9, 2019

I forgot regression tests... and they give an immediate answer to the need of making that decoration optional!

@stale

This comment has been minimized.

Copy link

stale bot commented Apr 8, 2019

This pull request has been automatically marked as stale because it has not had any activity in the last month.
Please feel free to give a status update now, ping for review, or re-open when it's ready.
It will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@stale stale bot added the stale label Apr 8, 2019
@Berbe

This comment has been minimized.

Copy link
Contributor Author

Berbe commented Apr 10, 2019

The addition of an option seeming mandatory in order not to break regression tests, it requires too much work for something not deemed a pirority.

I'll keep the decoration for myself.

@Berbe Berbe closed this Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.