Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 40 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterprisesFix: Fluidsynth should not try to lock sample data in memory #7365
Conversation
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This does not solve the problem for me. Checking the return value of |
This comment has been minimized.
This comment has been minimized.
I'm not sure if moving the setint call up actually solves it, but it is probably more correct. |
This comment has been minimized.
This comment has been minimized.
It does not, I had already tried this. |
This comment has been minimized.
This comment has been minimized.
Tested this on my own Fedora 29 system with fluidsynth 1.1.11, and this patch does solve the |
This comment has been minimized.
This comment has been minimized.
Still does not work for me, but if it works for you, that's good. |
nielsmh commentedMar 10, 2019
This should avoid warnings about memory locking from Fluidsynth:
fluidsynth: warning: Failed to pin the sample data to RAM; swapping is possible.