Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #7371: Avoid dependency on foundations of town tile during saveload #7398

Merged
merged 1 commit into from May 11, 2019

Conversation

@nielsmh
Copy link
Contributor

@nielsmh nielsmh commented Mar 23, 2019

This is perhaps the simplest possible fix, but it also changes the position of town signs in some situations.

@PeterN
Copy link
Member

@PeterN PeterN commented Mar 23, 2019

I still think depending on anything as extensively as this before any savegame conversion has happened is asking for trouble.

@nielsmh
Copy link
Contributor Author

@nielsmh nielsmh commented Apr 1, 2019

I prefer this solution because it does not introduce a global state for whether to use one or another algorithm, and it does not introduce a state for whether the k-d trees are valid, since they are now always valid.

@stale
Copy link

@stale stale bot commented May 1, 2019

This pull request has been automatically marked as stale because it has not had any activity in the last month.
Please feel free to give a status update now, ping for review, or re-open when it's ready.
It will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@stale stale bot added the stale label May 1, 2019
@stale stale bot removed the stale label May 2, 2019
@PeterN
Copy link
Member

@PeterN PeterN commented May 10, 2019

Needs a rebase?

@glx22
Copy link
Contributor

@glx22 glx22 commented May 10, 2019

Hmm yes, it's victim of the docker failure

PeterN
PeterN approved these changes May 11, 2019
@nielsmh nielsmh merged commit c9fe6e7 into OpenTTD:master May 11, 2019
8 checks passed
@nielsmh nielsmh deleted the bug7371 branch May 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants