Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #7165: SmallMap::Erase(key) does not work correctly #7428

Merged
merged 2 commits into from Mar 28, 2019
Merged
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

Prev

Fix #7165: Const overload SmallMap::Contains(key) compared wrong types.

Const and non-const Find() have different return types.
  • Loading branch information
michicc committed Mar 27, 2019
commit 2be07ec652eef5a797de48704245c5b42b2f8b56
@@ -95,7 +95,7 @@ struct SmallMap : std::vector<SmallPair<T, U> > {
*/
inline bool Contains(const T &key) const
{
return this->Find(key) != this->End();
return this->Find(key) != std::vector<Pair>::end();
}

/**
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.