Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Dark Blue company and water were indistinguishable in small map. Make water darker. #7436

Merged
merged 1 commit into from Mar 29, 2019

Conversation

@SamuXarick
Copy link
Contributor

SamuXarick commented Mar 29, 2019

Dark Blue Company and Water were indistinguishable.

With patch:
Radingstone Transport, 2051-07-05

Without:
Radingstone Transport, 2051-09-09

Dark Blue Company and Water were indistinguishable.
@James103

This comment has been minimized.

Copy link
Contributor

James103 commented Mar 29, 2019

The exact colors are:
Dark Blue company: R40 G92 B164 (hex 285CA4) (38.5% filled)
Water: R28 G68 B140 (hex 1C448C) (30.72% filled)
Difference: R12 G24 B24 (hex 0C1818) (7.8125% raw difference)

@andythenorth

This comment has been minimized.

Copy link
Contributor

andythenorth commented Mar 29, 2019

How does this look with the other mini-map colours?

How does it affect newgrf industry map colours?

@SamuXarick

This comment has been minimized.

Copy link
Contributor Author

SamuXarick commented Mar 29, 2019

_legend_land_owners[i].colour = _colour_gradient[c->colour][5];

Alternative is to change this line to
_legend_land_owners[i].colour = _colour_gradient[c->colour][4];

Makes all company colours a tone darker.
Radingstone Transport, 2051-09-09#1

@planetmaker

This comment has been minimized.

Copy link
Contributor

planetmaker commented Mar 29, 2019

I can see two different hues of blue in the screenshot as provided in the first posting.

@PeterN
PeterN approved these changes Mar 29, 2019
@PeterN PeterN merged commit ed51fba into OpenTTD:master Mar 29, 2019
8 checks passed
8 checks passed
OpenTTD CI Build #20190329.2 succeeded
Details
OpenTTD CI (Linux commit-checker) Linux commit-checker succeeded
Details
OpenTTD CI (Linux linux-amd64-clang-3.8) Linux linux-amd64-clang-3.8 succeeded
Details
OpenTTD CI (Linux linux-amd64-gcc-6) Linux linux-amd64-gcc-6 succeeded
Details
OpenTTD CI (Linux linux-i386-gcc-6) Linux linux-i386-gcc-6 succeeded
Details
OpenTTD CI (MacOS) MacOS succeeded
Details
OpenTTD CI (Windows Win32) Windows Win32 succeeded
Details
OpenTTD CI (Windows Win64) Windows Win64 succeeded
Details
andythenorth added a commit to andythenorth/OpenTTD that referenced this pull request Mar 30, 2019
…or legibility against darker blue of sea introduced by OpenTTD#7436
michicc added a commit that referenced this pull request Mar 30, 2019
…or legibility against darker blue of sea introduced by #7436
@SamuXarick SamuXarick deleted the SamuXarick:darker-water branch Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.