Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Shorten engine rail type drop down in autoreplace window. #7448

Merged
merged 1 commit into from Mar 31, 2019

Conversation

@PeterN
Copy link
Member

PeterN commented Mar 30, 2019

In the autoreplace window, the rail type drop down is for choosing engines
of the given time. Many rail types do not have engines specifically designed for them,
and are merely compatible with other rail types. This list is thus unwieldy and many
options have no engines available.

As this drop down is for choosing engine rail type rather than compatible rail types,
we can list just the rail types explicitly listed by engines.

Picture shows the change, on the left is master with all rail types in the list (these are not duplicates, they are different rail types with the same string), on the right is this PR with just the rail types specified for engines.

railtype

src/rail_gui.cpp Show resolved Hide resolved
In the autoreplace window, the rail type drop down is for choosing engines
of the given time. Many rail types do not have engines specifically designed for them,
and are merely compatible with other rail types. This list is thus unwieldy and many
options have no engines available.

As this drop down is for choosing _engine_ rail type rather than compatible rail types,
we can list just the rail types explicitly listed by engines.
@PeterN PeterN force-pushed the PeterN:fix-autoreplace-railtype-dropdown branch from a477adc to 1cdb2f4 Mar 30, 2019
@PeterN PeterN merged commit 6d1cc14 into OpenTTD:master Mar 31, 2019
8 checks passed
8 checks passed
OpenTTD CI Build #20190331.2 succeeded
Details
OpenTTD CI (Linux commit-checker) Linux commit-checker succeeded
Details
OpenTTD CI (Linux linux-amd64-clang-3.8) Linux linux-amd64-clang-3.8 succeeded
Details
OpenTTD CI (Linux linux-amd64-gcc-6) Linux linux-amd64-gcc-6 succeeded
Details
OpenTTD CI (Linux linux-i386-gcc-6) Linux linux-i386-gcc-6 succeeded
Details
OpenTTD CI (MacOS) MacOS succeeded
Details
OpenTTD CI (Windows Win32) Windows Win32 succeeded
Details
OpenTTD CI (Windows Win64) Windows Win64 succeeded
Details
@PeterN PeterN deleted the PeterN:fix-autoreplace-railtype-dropdown branch Mar 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.