Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust violet smallmap colour 1 shade darker after #7436 #7450

Merged

Conversation

@andythenorth
Copy link
Contributor

andythenorth commented Mar 30, 2019

#7436 changed the smallmap sea blue, so that it no longer conflates with dark blue company colour. That is a clear improvement generally.

However the smallmap colour options include violet. For me, following this change, whilst the blue and the violet are distinguishable as separate colours in the smallmap, the coastline is now very undifferentiated and hard to see the shape of.

This is highly subjective, and no-one else who tried could replicate the issue. My display has a currently uncommon P3 wide-gamut colour space, which is likely a factor. Notably other wide-gamut displays may be implementing the alternative Adobe RGB colour space, which has a wider range of blues than P3. Simulating Adobe RGB on my display does reduces the problem, which adds weight to the idea that this is caused by colour spaces.

So after that fascinating tour into colour spaces, I made the violet 1 shade darker than previously.

Which fixes the problem.

I can't find any negative side effects.

I tested for legibility problems with company colours, they're all fine to my eye.

A number of other people in irc compared the before and after, and nobody reported any problems at the time of writing.

Violet smallmap after 7436
sea_went_away

Violet smallmap as adjusted by this PR
sea_came_back

Things I also considered and rejected here:

  • I tested violet 2 shades darker, but 1 shade darker is fine
  • I tested adjustments to both the green smallmap options, this confirmed that the greens are ok 'as is', no change necessary
  • I considered changing the violet heightmap range, but it looks fine 'as is' to my eye, no change there. Notably the green smallmap option uses completely different hue for flat / heightmap

I'm using 'smallmap' because that's what it's called in settings GUI. I usually call it mini-map, but eh :)

…or legibility against darker blue of sea introduced by #7436
@glx22
glx22 approved these changes Mar 30, 2019
@michicc michicc merged commit 423aea5 into OpenTTD:master Mar 30, 2019
8 checks passed
8 checks passed
OpenTTD CI Build #20190330.24 succeeded
Details
OpenTTD CI (Linux commit-checker) Linux commit-checker succeeded
Details
OpenTTD CI (Linux linux-amd64-clang-3.8) Linux linux-amd64-clang-3.8 succeeded
Details
OpenTTD CI (Linux linux-amd64-gcc-6) Linux linux-amd64-gcc-6 succeeded
Details
OpenTTD CI (Linux linux-i386-gcc-6) Linux linux-i386-gcc-6 succeeded
Details
OpenTTD CI (MacOS) MacOS succeeded
Details
OpenTTD CI (Windows Win32) Windows Win32 succeeded
Details
OpenTTD CI (Windows Win64) Windows Win64 succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.