Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Adjust violet smallmap colour 1 shade darker after #7436 #7450
#7436 changed the smallmap sea blue, so that it no longer conflates with dark blue company colour. That is a clear improvement generally.
However the smallmap colour options include violet. For me, following this change, whilst the blue and the violet are distinguishable as separate colours in the smallmap, the coastline is now very undifferentiated and hard to see the shape of.
This is highly subjective, and no-one else who tried could replicate the issue. My display has a currently uncommon P3 wide-gamut colour space, which is likely a factor. Notably other wide-gamut displays may be implementing the alternative Adobe RGB colour space, which has a wider range of blues than P3. Simulating Adobe RGB on my display does reduces the problem, which adds weight to the idea that this is caused by colour spaces.
So after that fascinating tour into colour spaces, I made the violet 1 shade darker than previously.
Which fixes the problem.
I can't find any negative side effects.
I tested for legibility problems with company colours, they're all fine to my eye.
A number of other people in irc compared the before and after, and nobody reported any problems at the time of writing.
Things I also considered and rejected here:
I'm using 'smallmap' because that's what it's called in settings GUI. I usually call it mini-map, but eh :)