Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Remove AutoDeleteSmallVector and AutoFreeSmallVector #7453
Remove the last remains of SmallVector. For the replacement,
This got a bit bigger than expected and picked up some unrelated fixes I saw when in the area.
…ing AutoDeleteSmallVector obsolete. DropDownListItem are strongly managed using std::unique_ptr to ensure leak-free handling. Appropriate use of move-semantics make intent a lot clearer than parameter comments and allows the compiler to generate copy-free code for most situations.
The last use was for storing a list of memory blocks. As the way these lists are accessed is very specific, it is easier to just write an explicit destructor instead of trying to exactly match the behaviour.
In the literal sense: No.
In the less literal sense: Many current compilers will perform copy elision where possible, which means even the move assignment is likely to be optimized out.