Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Restore libtimidity #7454
I would like that we only accept this if we have some CI running this part of the code to validate it is still functioning correctly. Given there is no Debian port (which the CI runs), this might be a bit tricky.
As mentioned on IRC, as this is part of EmScripten wasm port, possibly it is good to combine that: upstream wasm port, re-introduce libtimidity, and have a Docker compiling for wasm on every compile (or every release / night). That makes sure libtimidity keeps working.
Without that, I am not sure we should accept this PR upstream. Having code that we cannot test is just asking for trouble :(
If you don't mind, I am going to close this Pull Request. Not because I think it is bad, but because I would rather focus on bringing this in together with Emscripten (as mentioned earlier). I will also work on integrating that with the CI, so this library gets tested on a regular basis :)