Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Self-adjusting AI/GS max opcodes #7459

Closed

Conversation

@SamuXarick
Copy link
Contributor

SamuXarick commented Apr 2, 2019

This is an experimentation so far. Goal is to permit playable framerate with many AIs running. Based on the performance data measured, the value of max opcodes is increased / decrease every GameLoop.

@PeterN

This comment has been minimized.

Copy link
Member

PeterN commented Apr 2, 2019

Regression testing is never going to work with this.

SamuXarick added 3 commits Apr 2, 2019
@SamuXarick

This comment has been minimized.

Copy link
Contributor Author

SamuXarick commented Apr 2, 2019

TODO: deprecate script_max_opcode_till_suspend (remove from savegames, etc...)
BTW, Regression should have failed. Must check why it didn't.

@TrueBrain TrueBrain added the wip label Apr 2, 2019
@TrueBrain

This comment has been minimized.

Copy link
Member

TrueBrain commented Apr 2, 2019

Although I appreciate experimenting, I do not think this has a place in OpenTTD. Patches like this are solving the wrong problem, in my opinion. It only means that people on low-end computers have a lesser experience than those on a high-end. It also means that games are completely undeterministic now as soon as an AI is involved. I can only see more bug tickets happening because of this.

Of course, you are more than welcome to experiment further with this, and see where it ends up. But I do not think it should be an active Pull Request, where we can see every change you make to this while experimenting :)

@TrueBrain TrueBrain closed this Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.