Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Industry coverage area is no longer rectangular. #7464

Merged
merged 1 commit into from Apr 13, 2019

Conversation

Projects
None yet
2 participants
@PeterN
Copy link
Member

PeterN commented Apr 3, 2019

AIs test station catchment in reverse to how players see station catchment.
This did not take account of non-rectangular station catchment areas, so AIs
could end up placing stations in locations that did not accept/deliver cargo.

@PeterN PeterN added this to the 1.10.0 milestone Apr 3, 2019

@PeterN

This comment has been minimized.

Copy link
Member Author

PeterN commented Apr 4, 2019

Needs a map bounds check to be added. Working on a separate branch that deduplicates the existing checks involving TileArea.

@PeterN

This comment has been minimized.

Copy link
Member Author

PeterN commented Apr 5, 2019

Updating this now depends on #7467

@PeterN PeterN force-pushed the PeterN:industry-catchment branch from 76d8e1f to de32cd4 Apr 7, 2019

@PeterN

This comment has been minimized.

Copy link
Member Author

PeterN commented Apr 7, 2019

Updated to depend on #7467. Now uses TileArea::Expand() which does bounds checking, which was previously missing in this PR.

@PeterN PeterN force-pushed the PeterN:industry-catchment branch from de32cd4 to 5151623 Apr 11, 2019

Fix: Industry coverage area is no longer rectangular.
AIs test station catchment in reverse to how players see station catchment.
This did not take account of non-rectangular station catchment areas, so AIs
could end up placing stations in locations that did not accept/deliver cargo.

@PeterN PeterN force-pushed the PeterN:industry-catchment branch from 5151623 to 7668023 Apr 13, 2019

@PeterN PeterN merged commit 3bbd7ea into OpenTTD:master Apr 13, 2019

@PeterN PeterN deleted the PeterN:industry-catchment branch Apr 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.