Add: Dropdown build menus from toolbar have icons #7485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterN
previously requested changes
Apr 7, 2019
|
Not really sure what this adds. The idea with rails and roads is it gives something to differentiate the different types, but with these menus we are not dealing with types. |
|
I do understand the original reason to add the icons to the menus. |
PeterN
previously requested changes
Apr 27, 2019
Does not build when rebased to master, needs the DropDownLists to be updated as in master.
PeterN
reviewed
Apr 27, 2019
PeterN
approved these changes
Apr 29, 2019
douiwby
pushed a commit
to douiwby/OpenTTD
that referenced
this issue
Apr 16, 2020
spnda
added a commit
to spnda/OpenTTD
that referenced
this issue
Jun 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Lately, the rail and road drop down menus have received icons for each entry in the menu.
I think, it looks strange if only 2 from 5 menus have these icons. And I wouldn't mind if every dropdown menu from the toolbar received these Icons, but that would require some new sprites.