Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Dropdown build menus from toolbar have icons #7485

Merged
merged 1 commit into from Apr 29, 2019

Conversation

spnda
Copy link
Contributor

@spnda spnda commented Apr 7, 2019

Lately, the rail and road drop down menus have received icons for each entry in the menu.
I think, it looks strange if only 2 from 5 menus have these icons. And I wouldn't mind if every dropdown menu from the toolbar received these Icons, but that would require some new sprites.

PeterN
PeterN previously requested changes Apr 7, 2019
src/toolbar_gui.cpp Outdated Show resolved Hide resolved
src/toolbar_gui.cpp Outdated Show resolved Hide resolved
@PeterN
Copy link
Member

@PeterN PeterN commented Apr 7, 2019

Not really sure what this adds. The idea with rails and roads is it gives something to differentiate the different types, but with these menus we are not dealing with types.

@spnda
Copy link
Contributor Author

@spnda spnda commented Apr 7, 2019

I do understand the original reason to add the icons to the menus.
Though due to this the menus are not very consistent. Having these icons in other menus other than rail and road make the menus more consistent and it would also be a bit more filled, as it is quite empty just having text.

@PeterN PeterN dismissed their stale review Apr 10, 2019

Resolved

LordAro
LordAro previously approved these changes Apr 27, 2019
Copy link
Member

@LordAro LordAro left a comment

No harm in it, and a little consistency never went amiss

PeterN
PeterN previously requested changes Apr 27, 2019
Copy link
Member

@PeterN PeterN left a comment

Does not build when rebased to master, needs the DropDownLists to be updated as in master.

src/toolbar_gui.cpp Outdated Show resolved Hide resolved
@PeterN PeterN dismissed their stale review Apr 28, 2019

Resolved

PeterN
PeterN approved these changes Apr 29, 2019
@PeterN PeterN merged commit 8cc6ee6 into OpenTTD:master Apr 29, 2019
8 checks passed
@spnda spnda deleted the dropdownmenuicons branch May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants