Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Creating a cargo subsidy with a town as source was not considering min population. #7493

Merged
merged 1 commit into from Apr 11, 2019

Conversation

SamuXarick
Copy link
Contributor

@SamuXarick SamuXarick commented Apr 10, 2019

SUBSIDY_CARGO_MIN_POPULATION was defined but not used anywhere. I suppose it was for this.

@PeterN
Copy link
Member

@PeterN PeterN commented Apr 10, 2019

This was lost in 50e08f3 (r23408)

PeterN
PeterN previously requested changes Apr 10, 2019
Copy link
Member

@PeterN PeterN left a comment

This additional test can be moved up to just under the line where Town::GetRandom() is called. This will avoid needlessly testing and iterating cargo.

@SamuXarick SamuXarick force-pushed the SUBSIDY_CARGO_MIN_POPULATION branch from 03bfbab to 3e22362 Compare Apr 10, 2019
@LordAro LordAro added the backport requested label Apr 10, 2019
PeterN
PeterN approved these changes Apr 11, 2019
@PeterN PeterN merged commit 4ad981a into OpenTTD:master Apr 11, 2019
8 checks passed
@SamuXarick SamuXarick deleted the SUBSIDY_CARGO_MIN_POPULATION branch Apr 11, 2019
PeterN pushed a commit to PeterN/OpenTTD that referenced this issue May 2, 2019
LordAro pushed a commit that referenced this issue May 28, 2019
@LordAro LordAro added backported and removed backport requested labels May 28, 2019
douiwby pushed a commit to douiwby/OpenTTD that referenced this issue Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants