Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Consider any cargo with passenger town effect for passenger-type subsidies. #7498

Closed
wants to merge 1 commit into from

Conversation

@PeterN
Copy link
Member

PeterN commented Apr 11, 2019

Subsidies are hardcoded to treat CT_PASSENGERS specially.

This change changes this so that any cargo type with TE_PASSENGERS is treated this way (e.g. Tourists from ECS Town)

@nielsmh
Copy link
Contributor

nielsmh commented Apr 24, 2019

Looks about right. Are there any other "alternate passengers" than ECS Tourists around?

@frosch123
Copy link
Member

frosch123 commented Apr 24, 2019

According to
https://newgrf-specs.tt-wiki.net/wiki/Action0/Cargos#Substitute_type_and_multiplier_for_town_growth_.2818.2C_19.29
the influence of the town effect onto subsidies was explicitly removed in OTTD 1.2.

I feel like there was a better method added to detect which cargos are produced/delivered by/to towns/industires.

@PeterN
Copy link
Member Author

PeterN commented Apr 25, 2019

Interesting, and it does work. I wonder if instead the specialisation for CT_PASSENGERS should be removed

@LordAro LordAro added the wip label Apr 27, 2019
@PeterN PeterN closed this May 2, 2019
@PeterN PeterN deleted the PeterN:subsidy-te-passengers branch May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.