Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use std::sort() when it's possible #7501

Merged
merged 4 commits into from Apr 13, 2019
Merged

Use std::sort() when it's possible #7501

merged 4 commits into from Apr 13, 2019

Conversation

@glx22
Copy link
Contributor

@glx22 glx22 commented Apr 11, 2019

Not replaced QSortT() calls are for C-style arrays.

@PeterN
Copy link
Member

@PeterN PeterN commented Apr 12, 2019

Can we use the struct operator() form in some places?

src/engine_gui.cpp Outdated Show resolved Hide resolved
@glx22
Copy link
Contributor Author

@glx22 glx22 commented Apr 12, 2019

Hmm yes, it should be possible to use operator() in some places.

src/fios.h Outdated Show resolved Hide resolved
@glx22 glx22 force-pushed the sort branch 2 times, most recently from ff2778c to 0a913a4 Apr 12, 2019
@glx22
Copy link
Contributor Author

@glx22 glx22 commented Apr 12, 2019

Now using operator<. Seems more appropriate.

src/fios.h Outdated Show resolved Hide resolved
@PeterN PeterN merged commit 801cbea into OpenTTD:master Apr 13, 2019
8 checks passed
@glx22 glx22 deleted the sort branch Apr 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants