Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Allow or disallow large aeroplanes to land on airports with short runways #7502

Closed

Conversation

@SamuXarick
Copy link
Contributor

SamuXarick commented Apr 12, 2019

For people who want to test this in-game, I suggest combining #7502 + #7503 + #7505, to better understand what's the intention being presented here. Experiment giving orders, sending to hangar and autoreplacing aircraft of different types on different airports.

@SamuXarick SamuXarick force-pushed the SamuXarick:large-plane-on-short-runway branch from c37e003 to e662dfb Apr 12, 2019
@PeterN

This comment has been minimized.

Copy link
Member

PeterN commented Apr 12, 2019

Apart from 151 lines of code, what does this actually add?

@SamuXarick

This comment has been minimized.

Copy link
Contributor Author

SamuXarick commented Apr 12, 2019

Force players to use the right aircraft/airport types for once. Just look at 1.9 title savegame.

More options for setting up servers, via max station spread, forcing small airports, while also forcing small aircraft type on them.

Also, in case of using unknown NewGRFs, it can also help by always pointing to the correct aircraft models for airports.

@Eddi-z

This comment has been minimized.

Copy link
Contributor

Eddi-z commented Apr 12, 2019

how does this need 150 lines instead of... 10?

@SamuXarick

This comment has been minimized.

Copy link
Contributor Author

SamuXarick commented Apr 12, 2019

Because the setting could be switched while airplanes were heading to hangars. It is to ensure that the same hangar is reachable, or to pick another.

Code also needs to prevent aircraft orders on incompatible airports/hangars.

@SamuXarick

This comment has been minimized.

Copy link
Contributor Author

SamuXarick commented Apr 12, 2019

Needs #7503 for a more user friendly autoreplace (but not really a must have)

actually, autoreplace needs more changes than just a gui change :( On second thought, it doesn't.
What to do about autoreplace:
Looks like nothing has to be done. I can replace a small plane with a large plane. If the airports have long runways, it's fine, if they don't it's not fine, but autoreplace, itself... nothing changes.

@SamuXarick SamuXarick force-pushed the SamuXarick:large-plane-on-short-runway branch from 52f0c46 to 6cb8ac2 Apr 13, 2019
@LordAro

This comment has been minimized.

Copy link
Member

LordAro commented Apr 27, 2019

I don't think this is going to go anywhere, I'm afraid

In theory, I like the idea of not being able to route large planes to small airports, but existing behaviour must be preserved, and I can't imagine adding an extra setting will interact well with the existing plane crash setting, or indeed the cheat for not crashing planes (which to be fair, could be removed)

There's already a news item for when planes are routed incorrectly STR_NEWS_PLANE_USES_TOO_SHORT_RUNWAY, and given the increased chance of crashing, I figure it's probably fine the way it is

@LordAro LordAro closed this Apr 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.