Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add aircraft type dropdown in Autoreplace window #7503

Open
wants to merge 1 commit into
base: master
from

Conversation

@SamuXarick
Copy link
Contributor

SamuXarick commented Apr 12, 2019

a) Adds an Aircraft type dropdown for the Autoreplace window, with 5 possible choices to pick from.

a1) 'All aircraft types' - Lists, on the right side, all aircraft types, regardless of the type of aircraft selected on the left side.

a2) 'Same aircraft type' - Lists, on the right side, only aircraft that match the type of aircraft selected on the left side.

  • if a helicopter is selected on the left side, then on the right side, only helicopters are listed.
  • if a small aeroplane is selected on the left side, then on the right side, only small aeroplanes are listed.
  • if a large aeroplane is selected on the left side, then on the right side, only large aeroplanes are listed.

a3) 'Helicopter' - Lists, on the right side, only helicopters, regardless of the type of aircraft selected on the left side.

a4) 'Small aeroplane' - Lists, on the right side, only small aeroplanes, regardless of the type of aircraft selected on the left side.

a5) 'Large aeroplane' - Lists, on the right side, only large aeroplanes, regardless of the type of aircraft selected on the left side.

b) This allows helicopters to be autoreplaced with aeroplanes and vice versa. Failure to do so would mean the replacement is being done in an incompatible hangar, but at least the possibility is there. Posted separate, as #7505

@PeterN
Copy link
Member

PeterN commented Apr 12, 2019

Not keen on sneaking the Heli/plane check away in what should be gui only changes

@stale
Copy link

stale bot commented May 13, 2019

This pull request has been automatically marked as stale because it has not had any activity in the last month.
Please feel free to give a status update now, ping for review, or re-open when it's ready.
It will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@stale stale bot added the stale label May 13, 2019
@SamuXarick SamuXarick force-pushed the SamuXarick:autoreplace-aircraft-type-dropdown branch from 8ba675e to ff53f18 Jul 18, 2019
@andythenorth
Copy link
Contributor

andythenorth commented Nov 2, 2019

As there has been no activity on this PR for some, I'm proposing closing it in a few weeks if nothing more has changed, as we try to keep the PR count low. Thanks for contributing!

@SamuXarick SamuXarick force-pushed the SamuXarick:autoreplace-aircraft-type-dropdown branch 2 times, most recently from 5623390 to 44248ef Dec 29, 2019
Adds an Aircraft type dropdown for the Autoreplace window, with 5 possible choices to pick from.

1) 'All aircraft types' - Lists, on the right side, all aircraft types, regardless of the type of aircraft selected on the left side.

2) 'Same aircraft type' - Lists, on the right side, only aircraft that match the type of aircraft selected on the left side.
- if a helicopter is selected on the left side, then on the right side, only helicopters are listed.
- if a small aeroplane is selected on the left side, then on the right side, only small aeroplanes are listed.
- if a large aeroplane is selected on the left side, then on the right side, only large aeroplanes are listed.

3) 'Helicopter' - Lists, on the right side, only helicopters, regardless of the type of aircraft selected on the left side.

4) 'Small aeroplane' - Lists, on the right side, only small aeroplanes, regardless of the type of aircraft selected on the left side.

5) 'Large aeroplane' - Lists, on the right side, only large aeroplanes, regardless of the type of aircraft selected on the left side.
@SamuXarick SamuXarick force-pushed the SamuXarick:autoreplace-aircraft-type-dropdown branch from 44248ef to 87a19f8 Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.