Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Hide block signal tools by default #7504

Closed
wants to merge 1 commit into from

Conversation

@nielsmh
Copy link
Contributor

@nielsmh nielsmh commented Apr 12, 2019

Please stop building block signals and especially pre-signals. They're for the most part a bad idea and your networks will function much better with PBS. Let's hide it behind an Expert level setting.

default:
break;
}
}
Copy link
Member

@PeterN PeterN Apr 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't there a better way to hide widgets? Planes or something?

Copy link
Contributor Author

@nielsmh nielsmh Apr 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only planes I've had success finding anything about in OTTD are airplanes, but there may be some corner of NUI that I still haven't discovered exists.

Copy link
Contributor Author

@nielsmh nielsmh Apr 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah an attempt at wrapping the buttons with an NWID_SELECTION on each row caused massive problems, it's much more trouble than worth to do it "the right way". May as well re-do the entire signals UI then.

@@ -1556,6 +1556,8 @@ STR_CONFIG_SETTING_SEMAPHORE_BUILD_BEFORE_DATE :Automatically b
STR_CONFIG_SETTING_SEMAPHORE_BUILD_BEFORE_DATE_HELPTEXT :Set the year when electric signals will be used for tracks. Before this year, non-electric signals will be used (which have the exact same function, but different looks)
STR_CONFIG_SETTING_ENABLE_SIGNAL_GUI :Enable the signal GUI: {STRING2}
STR_CONFIG_SETTING_ENABLE_SIGNAL_GUI_HELPTEXT :Display a window for choosing signal types to build, instead of only window-less signal-type rotation with Ctrl+clicking on built signals
STR_CONFIG_SETTING_SHOW_BLOCKSIGNALS :Enable building block signals: {STRING2}
STR_CONFIG_SETTING_SHOW_BLOCKSIGNALS_HELPTEXT :Show the tools for building block signals and pre-signals. Usage of block signals and path signals is discouraged, since path signals usually solve the same problems better. Existing block signals will continue working.
Copy link
Member

@LordAro LordAro Apr 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a fan of this, reads as very disparaging to the user. Something like "Block & pre(not path!) signals are intended for advanced users only"

@@ -1556,6 +1556,8 @@ STR_CONFIG_SETTING_SEMAPHORE_BUILD_BEFORE_DATE :Automatically b
STR_CONFIG_SETTING_SEMAPHORE_BUILD_BEFORE_DATE_HELPTEXT :Set the year when electric signals will be used for tracks. Before this year, non-electric signals will be used (which have the exact same function, but different looks)
STR_CONFIG_SETTING_ENABLE_SIGNAL_GUI :Enable the signal GUI: {STRING2}
STR_CONFIG_SETTING_ENABLE_SIGNAL_GUI_HELPTEXT :Display a window for choosing signal types to build, instead of only window-less signal-type rotation with Ctrl+clicking on built signals
STR_CONFIG_SETTING_SHOW_BLOCKSIGNALS :Enable building block signals: {STRING2}
Copy link
Member

@LordAro LordAro Apr 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe "Enable block signal GUI", as per "Enable the signal GUI" above. Or perhaps it should just be rolled into the same setting and be made a tri-state

@nielsmh
Copy link
Contributor Author

@nielsmh nielsmh commented Apr 13, 2019

Honestly this is a poor solution to the wrong problem, I'll rather remake the signals UI entirely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants