Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Permit autoreplacing a plane with a helicopter or vice versa. #7505

Conversation

@SamuXarick
Copy link
Contributor

@SamuXarick SamuXarick commented Apr 12, 2019

This allows helicopters to be autoreplaced with aeroplanes and vice versa. Failure to do so would mean the replacement is being done in an incompatible hangar, but at least the possibility is there.

This allows helicopters to be autoreplaced with aeroplanes and vice versa. Failure to do so would mean the replacement is being done in an incompatible hangar, but at least the possibility is there.
@TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Apr 13, 2019

This, to me, makes no sense at all.

Given you once again don't explain why you would want this, just what it does, I have no reason to believe my opinion is invalid.

So thank you for this contribution, but I am going to kindly decline this feature.

@TrueBrain TrueBrain closed this Apr 13, 2019
@SamuXarick
Copy link
Contributor Author

@SamuXarick SamuXarick commented Apr 13, 2019

Why you want split PRs and then you end up closing parts of it. Of course this makes little sense alone.

This PR was part of 7503, I was basically told to remove it from 7503. If 7502 is implemented, but this one is closed, you might as well just close 7502 and 7503, then! They don't make sense separated, but they do as a whole.

I was at first, making all these 3, a single PR, which would probably be closed anyway. I don't get it. I know how to present my PRs, if they're just 1.

@SamuXarick
Copy link
Contributor Author

@SamuXarick SamuXarick commented Apr 13, 2019

there is no difference in replacing a small plane with a large plane to replacing a helicopter with a plane if 7502 is implemented. if one is permited, the other should be too

@PeterN
Copy link
Member

@PeterN PeterN commented Apr 13, 2019

Hi Samu, I never said to split it, I said it was a bad idea to sneak such a change in with what is just a UI filter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants