Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Really check for start_date once an AI company slot becomes available. #7515

Conversation

@SamuXarick
Copy link
Contributor

SamuXarick commented Apr 15, 2019

basically, if there's no slots, it checks daily, using the interval 3601 - 3600
and never reaches 0
if it gets a start_date lower than that 3601-3600 interval, then the real countdown starts, using that start_date value. When it reaches 0, it tries to make ai company

@LordAro
Copy link
Member

LordAro commented Apr 15, 2019

This seems like a hack to me. The better solution is to redo the whole start_date thing to be more sane, understandable and predictable - this start_date thing has come up far too often

@stale
Copy link

stale bot commented May 15, 2019

This pull request has been automatically marked as stale because it has not had any activity in the last month.
Please feel free to give a status update now, ping for review, or re-open when it's ready.
It will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@stale stale bot added the stale label May 15, 2019
@glx22
Copy link
Contributor

glx22 commented Dec 22, 2019

The rework done in #7661 seems better to me, so I'm closing this PR.

@glx22 glx22 closed this Dec 22, 2019
@SamuXarick SamuXarick deleted the SamuXarick:check-for-start_date-once-an-AI-company-slot-becomes-available branch Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.