Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add soundfont path for Flatpak #7522

Closed
wants to merge 1 commit into from
Closed

Conversation

@ghisvail
Copy link

ghisvail commented Apr 18, 2019

Closes #6873

Closes #6873
@LordAro

This comment has been minimized.

Copy link
Member

LordAro commented Apr 18, 2019

Incorrect commit message caused the CI failure - should start with Add: ...

But, I wonder whether flatpak is "notable" enough to be included in the default lookup list, as it is just a default - you can specify your own file with ./bin/openttd -m fluidsynth:soundfont=foobar

@ghisvail

This comment has been minimized.

Copy link
Author

ghisvail commented Apr 19, 2019

Incorrect commit message caused the CI failure - should start with Add: ...

Interesting.

But, I wonder whether flatpak is "notable" enough to be included in the default lookup list,

Definition of notable is subjective. Linux market share in the gaming space is below 1% according to the latest Steam survey, so not much notable already. In addition, you've got fragmentation in the Linux distribution space with all these different distros, which may install stuff under different locations.

Flatpak provides a uniform medium of distribution and is supported by pretty much all the main family of distros today. In my opinion, it does not cost much to add a Flatpak specific entry to the search paths. The ideal solution would have been to enable injection of the soundfont path at build time via a configuration option...

you can specify your own file with ./bin/openttd -m fluidsynth:soundfont=foobar

...or at runtime via a command arg.

I wished I were advised about the existence of this feature back when I reported #6873 last year. Anyway.

Just for validation, this should work then:

./bin/openttd -m fluidsynth:soundfont=/app/share/sounds/sf2/FluidR3_GM.sf2

?

@PeterN

This comment has been minimized.

Copy link
Member

PeterN commented May 11, 2019

Can you fix your commit message to comply with our commit checker requirements?

@LordAro

This comment has been minimized.

Copy link
Member

LordAro commented Aug 17, 2019

Going to close this (and associated issue) as there's been no activity for 3 months, and it looks like there's an alternative solution anyway

@LordAro LordAro closed this Aug 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.